Hi All, I've been a Textmate user for a long time but I'm new here on the list. Recently the SVN commit pane changed from a dialog to a modal pane. I sent a message to feedback but was advised that I would be better raising it as a discussion here. I cannot find a previous thread that explains the design decision for the change.
I tend to open a full diff before starting the commit so that I can review my changes and write the commit message accordingly. Now I have to remember to double-click the tab of the diff file to move it to a separate window because the modality stops me from accessing the tabs. I also cannot browse the actual code on the tabs.
I presume that the modality change is to stop a novice from continuing to edit files before hitting Commit and therefore not necessarily committing everything? (I don't consider myself a novice). :-)
Cheers, Jonathan.
So what about the little arrow button at the bottom that opens the list of changed files and lets you show the diff as a separate window? m.
On Nov 6, 2014, at 4:10 AM, Jonathan Monahan jonathan@monahan.co.uk wrote:
I've been a Textmate user for a long time but I'm new here on the list. Recently the SVN commit pane changed from a dialog to a modal pane. I sent a message to feedback but was advised that I would be better raising it as a discussion here. I cannot find a previous thread that explains the design decision for the change.I tend to open a full diff before starting the commit so that I can review my changes and write the commit message accordingly. Now I have to remember to double-click the tab of the diff file to move it to a separate window because the modality stops me from accessing the tabs. I also cannot browse the actual code on the tabs.
I presume that the modality change is to stop a novice from continuing to edit files before hitting Commit and therefore not necessarily committing everything? (I don't consider myself a novice). :-)
-- matt neuburg, phd = http://www.apeth.net/matt/ pantes anthropoi tou eidenai oregontai phusei Programming iOS 7! http://shop.oreilly.com/product/0636920031017.do iOS 7 Fundamentals! http://shop.oreilly.com/product/0636920032465.do RubyFrontier! http://www.apeth.com/RubyFrontierDocs/default.html
On Thu, Nov 6, 2014 at 7:10 AM, Jonathan Monahan jonathan@monahan.co.uk wrote:
Hi All, I've been a Textmate user for a long time but I'm new here on the list. Recently the SVN commit pane changed from a dialog to a modal pane. I sent a message to feedback but was advised that I would be better raising it as a discussion here. I cannot find a previous thread that explains the design decision for the change.
See http://lists.macromates.com/textmate-dev/2014-July/014989.html and https://github.com/textmate/textmate/pull/1249 for previous discussions.
I tend to open a full diff before starting the commit so that I can review my changes and write the commit message accordingly. Now I have to remember to double-click the tab of the diff file to move it to a separate window because the modality stops me from accessing the tabs. I also cannot browse the actual code on the tabs.
Maybe we could change the SVN bundle to open full diffs in a new window? It's worth mentioning that if you cancel the commit (to browse the code), the message is saved in the "Previous Commit Messages" drop down, so when you open it again you can pick up where you were.
I presume that the modality change is to stop a novice from continuing to edit files before hitting Commit and therefore not necessarily committing everything? (I don't consider myself a novice). :-)
In short, the intention was mainly to prevent losing track of the commit dialog and having multiple commit windows open. There was a minor aesthetic reason too, since having buttons in the bottom bar looked "ugly" with a textured window.
I'm open to suggestions, though.
Cheers, Jonathan.
textmate mailing list textmate@lists.macromates.com http://lists.macromates.com/listinfo/textmate
On 6 Nov 2014, at 18:27, Ronald Wampler wrote:
I tend to open a full diff before starting the commit so that I can review my changes and write the commit message accordingly […]
Maybe we could change the SVN bundle to open full diffs in a new window?
This was also my first thought, as having the diff eclipsed by the commit window seemed to be the only complaint about using the modal sheet, did I get that right?
We already use an extenral window when showing uncommitted changes for Git which has the nice feature that line numbers (in that display) link back to the original documents. Additionally once TM supports re-running commands on changes, such output windows can be made “live”.
-
Allan Odgaard -
Jonathan Monahan -
Matt Neuburg -
Ronald Wampler