On 10 Apr 2014, at 4:12, Ronald Wampler wrote:
[…] Maybe we should also not send anything to the output window when canceling the commit too? So for this case (canceling) the other window would not be displayed at all.
I think this makes sense since there is no useful info in the window (after cancel).
[…] the git bundle labels the "update commit message" as "M" which tells the commit window to enable it by default.
I’ve always found this behavior confusing and would gladly see it replaced with just showing the message in the commit window where the user can then either keep it or edit it.
I do have a local change for the git bundle to include the last commit message automatically.
You mean always show the last commit message, even when we are not doing an ammend? I wouldn’t personally like that, but I believe that the “Previous Commit Messages” feature was originally done because someone had a lot of boilerplate in their commits, so wanted to re-use a majority of the last commit message.
If your scenario is similiar then perhaps allowing to set a template would be better.
As for the "enable by default", the status could be change to "?" or "X", I think, so that it is not enabled by default.
What does it mean to not have previous commit message enabled? That we are required to either enter a new message or enable it? I think we should strive for eliminating the item to clear up this confusion.
I am willing to submit pull requests to make the necessary changes to the git bundle to accommodate your comments, if that would be something of general interest.
I would be happy to merge a pull request for showing last commit message for ammend (not in general), not opening HTML output window for cancel, and setting auto-save frame name for commit window.
I don’t know if you extracted any potential visual tweaks from Jacob’s feedback. Tbh I am not too happy about the look of the bottom bar, but I haven’t been able to come up with something better. Apple’s guidelines say to try and avoid bottom bars and place actions in the toolbar instead, but that doesn’t seem right for this window, and they have similiar bottom bar themselves e.g. in the iCloud Open dialog (try Preview → Open). Though Apple’s top bar is much lighter, but also a bit non-standard (no close/minimize buttons).