When doing Ctrl-Shift-V to use PyChecker/Pyflakes/Pylint, I get a Python error.
Reason:
my_revision = __version__.split()[1]
on Line 346 assumes the __version__ from Line 26 can be split into at least 2 parts. However, Line 26 reads:
__version__ = "$Revision$"
When it should read:
__version__ = "$Revision 11734 $" # Not sure what Revision actually refers
to, Textmate or script version
I am using the latest available TextMate (r1505), with Python 2.6.2 on 10.5.8. However, this Command is most likely broken in every version of TextMate released since the error was first introduced, since it is a basic Python error. The feature was at least working in June 2008 according to this blog about it: http://arthurkoziel.com/2008/06/28/pyflakes-installation-and-textmate-integr...
Though I must say... What's the use of the revision, exactly?? It seems that it has only served to break the script and not much else. :)
I've gotten by for now by editing the Python bundle.
Thanks.
On 18 Aug 2009, at 21:46, J W-d wrote:
[...] Line 26 reads: __version__ = "$Revision$"
When it should read: __version__ = "$Revision 11734 $"
The revision is put into that line by svn if you cat/export/checkout the file.
I see however that the git mirror does not have this revision, so I am assuming you updated the bundle from git (maybe via GetBundles). We’ll need to address that (I didn’t know about it until now).
[...] Though I must say... What's the use of the revision, exactly?? It seems that it has only served to break the script and not much else. :)
The idea with the revision is that when a user reports that “I used ⌃⇧V and it gives me this error” we can ask the user what revision of the script he has, so we can see if it has since been fixed :)
On Wed, Aug 19, 2009 at 9:43 AM, Allan Odgaardmailinglist@textmate.org wrote:
On 18 Aug 2009, at 21:46, J W-d wrote:
[...] Line 26 reads: __version__ = "$Revision$"
When it should read: __version__ = "$Revision 11734 $"
The revision is put into that line by svn if you cat/export/checkout the file.
I see however that the git mirror does not have this revision, so I am assuming you updated the bundle from git (maybe via GetBundles). We’ll need to address that (I didn’t know about it until now).
[...] Though I must say... What's the use of the revision, exactly?? It seems that it has only served to break the script and not much else. :)
The idea with the revision is that when a user reports that “I used ⌃⇧V and it gives me this error” we can ask the user what revision of the script he has, so we can see if it has since been fixed :)
Ugh, I can fix this, but:
a) I need to pull up your message on how write access to the bundles work, since it's been a while since I touched anything (or I may just send a patch to the list...)
b) I'm not sure what the best alternative is for the svn tag, it may just be burning a revision into the source file on checkin and remembering to update it manually on each commit. :-(
j.
On 21 Aug 2009, at 17:13, Jay Soffian wrote:
On Wed, Aug 19, 2009 at 9:43 AM, Allan Odgaard<mailinglist@textmate.org
wrote: On 18 Aug 2009, at 21:46, J W-d wrote:
[...] Line 26 reads: __version__ = "$Revision$"
When it should read: __version__ = "$Revision 11734 $"
The revision is put into that line by svn if you cat/export/checkout the file.
I see however that the git mirror does not have this revision, so I am assuming you updated the bundle from git (maybe via GetBundles). We’ll need to address that (I didn’t know about it until now).
[...] Though I must say... What's the use of the revision, exactly?? It seems that it has only served to break the script and not much else. :)
The idea with the revision is that when a user reports that “I used ⌃⇧V and it gives me this error” we can ask the user what revision of the script he has, so we can see if it has since been fixed :)
Ugh, I can fix this, but:
a) I need to pull up your message on how write access to the bundles work, since it's been a while since I touched anything (or I may just send a patch to the list...)
Write bundles(at)textmate dot org for stuff related to svn access.
b) I'm not sure what the best alternative is for the svn tag, it may just be burning a revision into the source file on checkin and remembering to update it manually on each commit. :-(
I am not sure what a good fix is either, and this command is not the only one which use svn keywords. I sort of feel this should be fixed in the “script” that does the git mirroring, so if I were you, I’d leave it up to me to find a more universal fix for this problem.
Getting back to this issue from early September…
On 2 Sep 2009, at 18:13, Allan Odgaard wrote:
On 21 Aug 2009, at 17:13, Jay Soffian wrote:
On Wed, Aug 19, 2009 at 9:43 AM, Allan Odgaard wrote:
On 18 Aug 2009, at 21:46, J W-d wrote:
[...] Line 26 reads: __version__ = "$Revision$"
When it should read: __version__ = "$Revision 11734 $"
[…] b) I'm not sure what the best alternative is for the svn tag, it may just be burning a revision into the source file on checkin and remembering to update it manually on each commit. :-(
I am not sure what a good fix is either, and this command is not the only one which use svn keywords. I sort of feel this should be fixed in the “script” that does the git mirroring, so if I were you, I’d leave it up to me to find a more universal fix for this problem.
I looked into this, and we only have 4 uses of $Revision$ in all the bundles and since the mirror never went “automatic” I think we should just remove this and use other means to keep a revision number.
IOW would be nice if you’ll update the script to not use $Revision$.
On Tue, Nov 17, 2009 at 12:12 PM, Allan Odgaard mailinglist@textmate.org wrote:
I looked into this, and we only have 4 uses of $Revision$ in all the bundles and since the mirror never went “automatic” I think we should just remove this and use other means to keep a revision number.
IOW would be nice if you’ll update the script to not use $Revision$.
I seem to have lost access to Authentication realm: http://svn.textmate.org:80 TextMate Bundles
(To be clear, I've lost track of my username/password.). So here's the diff in-line and attached in-case gmail mangles it.
j.
---snip--- Index: pycheckmate.py =================================================================== --- pycheckmate.py (revision 11832) +++ pycheckmate.py (working copy) @@ -23,7 +23,7 @@ # Before sending updates to this code, please make sure you have the latest # version: http://macromates.com/wiki/pmwiki?n=Main.SubversionCheckout
-__version__ = "$Revision$" +__version__ = "1.0"
import sys import os @@ -343,8 +343,7 @@
def main(script_path): checker_bin, checker_opts, checker_ver = find_checker_program() - my_revision = __version__.split()[1] - version_string = "PyCheckMate r%s – %s" % (my_revision, checker_ver) + version_string = "PyCheckMate %s – %s" % (__version__, checker_ver) warning_string = "" if not checker_bin: href_format = \ ---snip---
On Fri, Nov 20, 2009 at 10:16 AM, Jay Soffian jaysoffian@gmail.com wrote:
(To be clear, I've lost track of my username/password.). So here's the diff in-line and attached in-case gmail mangles it.
I decided to be not-lame, cloned the github bundle, and pushed the change back. I sent a pull request.
j.
-
Allan Odgaard -
J W-d -
Jay Soffian