It is a bug that words surround by underscores in snake_case_words in a TextMate Twiki document are italicized. (In this example, the word "case" is italicized.) When displayed in TWiki, those words are not italicized.
I made a small change to the Twiki language (in the Twiki bundle) to correct this--see the 'markup.italic.twiki' match in the attached patch. While I was in there, I made the same change to the 'markup.bold.twiki' match. But I intentionally didn't change the 'markup.raw.fixed.twiki' match, since I don't think it's likely that someone will type a word with a pair of '=' embedded in it. Let me know if you think I should resubmit the patch with this change (or other changes) included.
-- Daryl
Is there something else I should do with this patch?
I didn't get a reply to this email (which I also BCCed to the email address from the Twiki bundle's info.plist--the contact name there is Stephen Skubik-Peplaski), and I haven't seen the patch applied on the bundles change log RSS feed.
If the Twiki bundle needs someone to maintain it, I'll volunteer.
-- Daryl
On 4/5/07, Daryl Spitzer daryl.spitzer@gmail.com wrote:
It is a bug that words surround by underscores in snake_case_words in a TextMate Twiki document are italicized. (In this example, the word "case" is italicized.) When displayed in TWiki, those words are not italicized.
I made a small change to the Twiki language (in the Twiki bundle) to correct this--see the 'markup.italic.twiki' match in the attached patch. While I was in there, I made the same change to the 'markup.bold.twiki' match. But I intentionally didn't change the 'markup.raw.fixed.twiki' match, since I don't think it's likely that someone will type a word with a pair of '=' embedded in it. Let me know if you think I should resubmit the patch with this change (or other changes) included.
-- Daryl
On 9. Apr 2007, at 17:58, Daryl Spitzer wrote:
Is there something else I should do with this patch?
I didn't get a reply to this email (which I also BCCed to the email address from the Twiki bundle's info.plist--the contact name there is Stephen Skubik-Peplaski), and I haven't seen the patch applied on the bundles change log RSS feed.
I have your original mail flagged as one of those I need to attend to ;)
If the Twiki bundle needs someone to maintain it, I'll volunteer.
If I don’t hear from Stephen, then that’d be appreciated. I’ll write you off list later.
On 5. Apr 2007, at 22:09, Daryl Spitzer wrote:
It is a bug that words surround by underscores in snake_case_words in a TextMate Twiki document are italicized. (In this example, the word "case" is italicized.) When displayed in TWiki, those words are not italicized.
I made a small change to the Twiki language (in the Twiki bundle) to correct this--see the 'markup.italic.twiki' match in the attached patch.
I got around to apply it, thanks.
While I was in there, I made the same change to the 'markup.bold.twiki' match.
This won’t work, since * is not a word character, so \b will actually have the opposite effect, i.e. making foo*bar*fud match the inner word as bold.
Instead it should probably be (?<!\w) and (?!\w) before/after the match. I didn’t make this change though.
I got around to apply it, thanks.
Thank you.
While I was in there, I made the same change to the 'markup.bold.twiki' match.
This won't work, since * is not a word character, so \b will actually have the opposite effect, i.e. making foo*bar*fud match the inner word as bold.
Oops. I got caught submitting a change without testing it. I don't seem capable of never repeating that mistake--that's where automated tests come in handy. (Which leads me to a question which I will post separately.)
Instead it should probably be (?<!\w) and (?!\w) before/after the match. I didn't make this change though.
I think you made the right call. Unlike snake_case_words, I have yet to run across a real-world need for asterisks embedded within words. We should wait to "fix" it until it is proven to be a problem.
-- Daryl
On 4/13/07, Allan Odgaard throw-away-1@macromates.com wrote:
On 5. Apr 2007, at 22:09, Daryl Spitzer wrote:
It is a bug that words surround by underscores in snake_case_words in a TextMate Twiki document are italicized. (In this example, the word "case" is italicized.) When displayed in TWiki, those words are not italicized.
I made a small change to the Twiki language (in the Twiki bundle) to correct this--see the 'markup.italic.twiki' match in the attached patch.
I got around to apply it, thanks.
While I was in there, I made the same change to the 'markup.bold.twiki' match.
This won't work, since * is not a word character, so \b will actually have the opposite effect, i.e. making foo*bar*fud match the inner word as bold.
Instead it should probably be (?<!\w) and (?!\w) before/after the match. I didn't make this change though.
For new threads USE THIS: textmate@lists.macromates.com (threading gets destroyed and the universe will collapse if you don't) http://lists.macromates.com/mailman/listinfo/textmate
-
Allan Odgaard -
Daryl Spitzer