macOS 10.13.1
I've also tried changing the shebang of gen_html to so it uses ruby 2.4.2 (from Homebrew) and the result is the same. Anyone else hitting this? Any workaround?
[266/740] Generate ‘/Users/dfelicia/build/TextMate/Applications/TextMate/TextMate.app/Contents/Resources/Contributions.html’… FAILED: /Users/dfelicia/build/TextMate/Applications/TextMate/TextMate.app/Contents/Resources/Contributions.html bin/gen_html > /Users/dfelicia/build/TextMate/Applications/TextMate/TextMate.app/Contents/Resources/Contributions.html~ -h Applications/TextMate/templates/header.html -f Applications/TextMate/templates/footer.html Applications/TextMate/about/Contributions.md Applications/TextMate/references.md && mv /Users/dfelicia/build/TextMate/Applications/TextMate/TextMate.app/Contents/Resources/Contributions.html~ /Users/dfelicia/build/TextMate/Applications/TextMate/TextMate.app/Contents/Resources/Contributions.html /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/erb.rb:861:in `eval': (erb):18: syntax error, unexpected &, expecting end-of-input (SyntaxError) ; ></p> ^ from /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/erb.rb:861:in `block in result' from /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/erb.rb:862:in `result' from bin/gen_html:29:in `expand_tpl' from bin/gen_html:114:in `block in <main>' from bin/gen_html:114:in `open' from bin/gen_html:114:in `<main>' [275/740] Compile xib ‘Applications/TextMate/resources/English.lproj/MainMenu.xib’… ninja: build stopped: subcommand failed.
I tried completely cleaning up, and also worked around the annoying ns/ns.h issue that was previously reported to this list, but the results is the same:
rm -rf ~/build rm -rf ~/github/local/textmate cd ~/github/local git clone https://github.com/textmate/textmate.git cd textmate git submodule update --init sed -i.bak 's%<ns/ns.h>%"/Users/dfelicia/github/local/textmate/Frameworks/ns/src/ns.h"%g' /Users/dfelicia/github/local/textmate/Frameworks/OakFoundation/src/OakFoundation.mm ./configure ninja
On 16 Nov 2017, at 1:19, Don Feliciano wrote:
macOS 10.13.1
I've also tried changing the shebang of gen_html to so it uses ruby 2.4.2 (from Homebrew) and the result is the same. Anyone else hitting this? Any workaround?
I am not yet on 10.13.1 so I don’t know what the issue is, however, as the error is from erb which is being used with this template https://github.com/textmate/textmate/blob/master/Applications/TextMate/about... then I assume that erb changed rules about “escaping”.
There are erb tags that use both `%` and `<<`. The former is used in the documentation for erb, so I think more likely it’s the latter that is causing the problem.
Can you try edit the above mentioned file to avoid `<<` and see if it helps?
On Nov 15, 2017, at 10:19 PM, Allan Odgaard mailinglist@textmate.org wrote:
I am not yet on 10.13.1 so I don’t know what the issue is, however, as the error is from erb which is being used with this template https://github.com/textmate/textmate/blob/master/Applications/TextMate/about... https://github.com/textmate/textmate/blob/master/Applications/TextMate/about/Contributions.md then I assume that erb changed rules about “escaping”.
There are erb tags that use both % and <<. The former is used in the documentation for erb, so I think more likely it’s the latter that is causing the problem.
Can you try edit the above mentioned file to avoid << and see if it helps?
Than you, Allan. This worked.
On 17 Nov 2017, at 0:58, Don Feliciano wrote:
Can you try edit the above mentioned file to avoid << and see if it helps?
Than you, Allan. This worked.
Does that mean changing `_erbout << "</ol>\n"` to e.g. `_erbout.concat("</ol>\n")` solved the problem?
If so, I can commit that change.
I've tried changing _erbout << "</ol>\n" to _erbout.concat("</ol>\n") but I still get the same error. I'm on macOS 10.13.2 with Xcode 9.2.
Allan Odgaard wrote:
On 17 Nov 2017, at 0:58, Don Feliciano wrote:
Can you try edit the above mentioned file to avoid << and see if it helps? Than you, Allan. This worked.Does that mean changing |_erbout << "</ol>\n"| to e.g. |_erbout.concat("</ol>\n")| solved the problem?
If so, I can commit that change.
textmate mailing list textmate@lists.macromates.com http://lists.macromates.com/listinfo/textmate
On 16 Dec 2017, at 0:07, Angelo Varlotta wrote:
I've tried changing _erbout << "</ol>\n" to _erbout.concat("</ol>\n") but I still get the same error. I'm on macOS 10.13.2 with Xcode 9.2.
Please try compile HEAD which includes this commit: https://github.com/textmate/textmate/commit/0c8817e57aa35aa95472fc66a4489f76...
Hi Allan, Yes, this commit works, after using:
|ninja -t clean| |./configure && ninja|
Thanks!
Allan Odgaard wrote:
On 16 Dec 2017, at 0:07, Angelo Varlotta wrote:
I've tried changing _erbout << "</ol>\n" to _erbout.concat("</ol>\n") but I still get the same error. I'm on macOS 10.13.2 with Xcode 9.2.Please try compile HEAD which includes this commit: https://github.com/textmate/textmate/commit/0c8817e57aa35aa95472fc66a4489f76...
-
Allan Odgaard -
Angelo Varlotta -
Don Feliciano