I've created a bundle for ESLint and I'd like to find out the requirements for submission to Textmate's bundle list in the preferences pane.
https://github.com/ryanfitzer/eslint.tmbundle
Thanks, Ryan
On 09.07.2016, at 07:18 , Ryan Fitzer ryanfitzer@gmail.com wrote:
I've created a bundle for ESLint and I'd like to find out the requirements for submission to Textmate's bundle list in the preferences pane.
There is already a textmate-eslint bundle, but yours looks really pretty.
One suggestion: Support eslint_d, which reduces eslint time by about 80%: https://www.npmjs.com/package/eslint_d
Thanks for you work Fabian
There is already a textmate-eslint bundle
Yes, there are a handful. Mine doesn't rely on a bundled version of ESLint, and therefore uses whichever version your project depends on. The other bundles I've reviewed either rely on a global install of `eslint` being available, or bundle their own version. Neither of which worked for my needs across many projects.
but yours looks really pretty
Thanks!
One suggestion: Support eslint_d, which reduces eslint time by about 80%
Thanks for the suggestion. Just took a look at it. To be honest, I hadn't really noticed any speed issues. After some profiling, the bundle executes in ~520ms, on average (MacBook Pro 2.5 GHz Intel Core i7). Definitely more than the ~160ms that eslint_d advertises, but I don't think the extra complexity and dependencies are worth it.
Again, I really appreciate your feedback.
Ryan
On 09.07.2016, at 20:09 , Ryan Fitzer ryan@ryanfitzer.com wrote:
One suggestion: Support eslint_d, which reduces eslint time by about 80%
Thanks for the suggestion. Just took a look at it. To be honest, I hadn't really noticed any speed issues. After some profiling, the bundle executes in ~520ms, on average (MacBook Pro 2.5 GHz Intel Core i7). Definitely more than the ~160ms that eslint_d advertises, but I don't think the extra complexity and dependencies are worth it.
I found it too be a huge difference. I run eslint everytime I save and with eslint_d the window just pops up immediately, not after half a second.
Again, I really appreciate your feedback.
You’re welcome, thanks for your work!
Fabian
Made some design tweaks and added keyboard access based on the feedback from this thread. Thanks, again.
https://github.com/ryanfitzer/eslint.tmbundle
Ryan
I've created a bundle for ESLint and I'd like to find out the requirements for submission to Textmate's bundle list in the preferences pane.
The UI is nice, but it has too much wasted space and requires using mouse to get to the problematic code.
So I think it's time for me to present my own solution to the linting problem.
https://github.com/Igor10k/Linter
Features: - Can be extended to support basically any linter. Out-of-the-box it's eslint, jscs and coffelint. - Tries using locally installed linters first. If fails tries the globally installed version. - Get to the problematic code by pressing the corresponding number of the error entry on the keyboard. - Just a single dependency - NodeJS. I'm planning a rewrite using Ruby to get rid of this too.
On Jul 9, 2016, at 12:56 PM, Igor Kozlov me@igorkozlov.me wrote:
The UI is nice, but it has too much wasted space and requires using mouse to get to the problematic code.
That's great feedback. I'll add in keyboard navigation. I also like the optimized use of space of your UI. I'll make some tweaks based on the efficiency of yours.
Ryan