Hello all,
I've prepared some updates to the PHP bundle to bring it up to date with PHP 5.3. This includes language grammar support for namespaces, closures, Nowdoc syntax, and a few other changes/updates. I also updated all of the functions.txt and functions.plist completions to PHP 5.3.1. I made some small changes to the generate.rb script and added a simple PHP script to populate the functions.plist file, so re-generating these should be a bit easier in the future. I forked the bundle on Github and pushed my changes there.
http://github.com/voxwerk/php.tmbundlhttp://github.com/voxwerk/php.tmbundle/commits/master e
I'm not really sure what to do next as far as getting feedback or who to send any patches to, so I figured firing off an email to the mailing list would be a good start.
Thanks everyone for doing such an awesome job on all of the bundles!
-Josh
On Mar 2, 2010, at 11:22 PM, Joshua Varner wrote:
Hello all,
I've prepared some updates to the PHP bundle to bring it up to date with PHP 5.3. This includes language grammar support for namespaces, closures, Nowdoc syntax, and a few other changes/updates. I also updated all of the functions.txt and functions.plist completions to PHP 5.3.1. I made some small changes to the generate.rb script and added a simple PHP script to populate the functions.plist file, so re-generating these should be a bit easier in the future. I forked the bundle on Github and pushed my changes there.
http://github.com/voxwerk/php.tmbundle
I'm not really sure what to do next as far as getting feedback or who to send any patches to, so I figured firing off an email to the mailing list would be a good start.
Thanks everyone for doing such an awesome job on all of the bundles!
-Josh
Now these are great news. I was searching for a more updated bundle to add my patches/fixes and the smart autocompletion system to. Great to see you've worked on this bundle already!
I'll give you feedback as soon as I have time. However, just by what you said it sounds like a really good update. If you wish to propose the update for the main bundle, you could contact Allan via IRC (he's always there): irc.freenode.org ##textmate
Please keep me posted on any updates through this list.
Thank you!
- Mario "Kuroir" Ricalde
On Mar 3, 2010, at 12:22 AM, Joshua Varner wrote:
I'm not really sure what to do next as far as getting feedback or who to send any patches to, so I figured firing off an email to the mailing list would be a good start.
Technology-wise, just click the “Pull Request” button on your fork’s page on GitHub. That will allow the reviewers of the official bundle to pull in your changes if they want.
Process-wise, I’m not sure if there are any steps they’d prefer prior to a pull request or not. If you don’t get any answers here, I’d just send the request.