I think you are correct. I come from a perforce environment and the ability to do what you described was somewhat alien to me. I'll have to look at the subversion way of doing things. Thanks for the information. Bob
On 4/17/07, Florian Gilcher flo@andersground.net wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I think you misunderstood my intention. With svn propset, you can set arbitrary properties for a single file/directory. That gives you the possibility to use a set of file properties to keep track. In combination with a hook script, you could mark every changed line as 'unreviewed' on commit, while your bundle manages the task of changing the property back to 'reviewed' and listing the properties. (simple scenario...)
A hook script on the server side has the advantage that no client has to support you system or even know about it unless he wants to review code.
Greetings Skade
Bob Henkel wrote:
I have thought about this and was thinking of using the TODO bundle to help out with this. I think avoiding the database approach would simplify things. It might not be as industrial strength, but is a much simpler implementation.
The usage would go something like this: A person enters TODO tags within the code such as --BUG OPEN BLH This code is junk fix it please! The The format could be something like --<TYPE> <STATE> <INITIALS> <COMMENT>
After someone reviews a file they submit it to source control with their review comments included in the source. The only problem I see is if two separate reviewers comment on the same line when it comes time to submit to source control who's comment wins? This is what leans me back to a database implementation. My assumption is that there may be 4 or more reviewers reviewing the same code at any given time.
Thanks Bob
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGJNk58RlGMqQ8m7oRAuOqAJ9JzIpxbmTCQqS7gkDA2u9BHdTnsQCfeaI9 xcFzGHkAOzt3rAQKwyzpO2Q= =jo5L -----END PGP SIGNATURE-----
For new threads USE THIS: textmate@lists.macromates.com (threading gets destroyed and the universe will collapse if you don't) http://lists.macromates.com/mailman/listinfo/textmate