[TxMt] Twiki Bundle patch

[Daryl Spitzer]

> I got around to apply it, thanks.

Thank you.

> > While I was in there, I made the same change to the
> > 'markup.bold.twiki' match.
>
> This won't work, since * is not a word character, so \b will actually
> have the opposite effect, i.e. making foo*bar*fud match the inner
> word as bold.

Oops.  I got caught submitting a change without testing it.  I don't
seem capable of never repeating that mistake--that's where automated
tests come in handy.  (Which leads me to a question which I will post
separately.)

> Instead it should probably be (?<!\w) and (?!\w) before/after the
> match. I didn't make this change though.

I think you made the right call.  Unlike snake_case_words, I have yet
to run across a real-world need for asterisks embedded within words.
We should wait to "fix" it until it is proven to be a problem.

--
Daryl


On 4/13/07, Allan Odgaard <throw-away-1 at macromates.com> wrote:
> On 5. Apr 2007, at 22:09, Daryl Spitzer wrote:
>
> > It is a bug that words surround by underscores in snake_case_words
> > in a TextMate Twiki document are italicized.  (In this example, the
> > word "case" is italicized.)  When displayed in TWiki, those words
> > are not italicized.
> >
> > I made a small change to the Twiki language (in the Twiki bundle)
> > to correct this--see the 'markup.italic.twiki' match in the
> > attached patch.
>
> I got around to apply it, thanks.
>
> > While I was in there, I made the same change to the
> > 'markup.bold.twiki' match.
>
> This won't work, since * is not a word character, so \b will actually
> have the opposite effect, i.e. making foo*bar*fud match the inner
> word as bold.
>
> Instead it should probably be (?<!\w) and (?!\w) before/after the
> match. I didn't make this change though.
>
>
>
>
> ______________________________________________________________________
> For new threads USE THIS: textmate at lists.macromates.com
> (threading gets destroyed and the universe will collapse if you don't)
> http://lists.macromates.com/mailman/listinfo/textmate
>