[SVN] Re: [PATCH] (ShellScript) Patch to “New Function”: add parentheses after function name

[Allan Odgaard]

Great to see the shell bundle receive some love! :)

I wonder though, if this is only to satisfy the highlight, why not  
improve the grammar instead to match functions without ()?

It looks like the grammar just matches ‘«something» ()’ as a function,  
but really, it is the function keyword that marks a function, right?  
So we can have the grammar match based on that instead.


On 17 Jan 2009, at 15:39, Martin Kühl wrote:

> Hi all,
>
> the current "New Function" command uses the "funcion $name {…}" format
> for shell functions, which the shell script grammar doesn't highlight
> correctly.
> This patch applies the easy fix of just using the "function $name ()
> {…}" form instead.
>
> Thanks,
> Martin
>
> Patch on pastie:
> http://pastie.textmate.org/private/wwnskgqicpf0vxcmic8lha
> <pastie-363251.diff>_______________________________________________
> textmate-dev mailing list
> textmate-dev at lists.macromates.com
> http://lists.macromates.com/listinfo/textmate-dev