The other day I did an SVN commit from textmate.
In the commit message window I pasted in some text I'd copied from a message from a client from BaseCamp.
When I tried to commit, it failed complaining about mixed line endings (paraphrasing from memory).
It seems to me that this is something that the subversion bundle could sanitize.
I tried to figure out how to patch this, but I think that this is all handled within the internal CommitWindow.app which I can't (or don't know how to) look at.
On Nov 16, 2007, at 10:16 AM, Rick DeNatale wrote:
The other day I did an SVN commit from textmate.
In the commit message window I pasted in some text I'd copied from a message from a client from BaseCamp.
When I tried to commit, it failed complaining about mixed line endings (paraphrasing from memory).
It seems to me that this is something that the subversion bundle could sanitize.
I tried to figure out how to patch this, but I think that this is all handled within the internal CommitWindow.app which I can't (or don't know how to) look at.
While we a collecting minor subversion annoyances, How about scanning the commit result message for errors and doing something visually louder when the commit fails? If your file is out of date you get a message that is very subdued in a window that looks pretty close to the one you get if it succeeds. I'm thinking big flashing red letters that says "Commit Failed", or something to that effect...
Matt
On 16 Nov 2007, at 17:16, Rick DeNatale wrote:
[...] When I tried to commit, it failed complaining about mixed line endings (paraphrasing from memory).
Never heard of such error before. Would that be the commit message itself that had the mixed line endings?
[...] I tried to figure out how to patch this, but I think that this is all handled within the internal CommitWindow.app which I can't (or don't know how to) look at.
The source for the CommitWindow is here: http://macromates.com/svn/Bundles/trunk/Tools/CommitWindowProject/
The Ruby script which uses the CommitWindow is here: http://macromates.com/svn/Bundles/trunk/Bundles/Subversion.tmbundle/Support/...
I wonder though if actually this is not more suitable for http://bugreport.apple.com -- although NSTextView can handle mixed line endings, I don’t think reading stuff from the clipboard should ever result in anything but LF. Maybe though you got RTF on the clipboard, and NSTextView inserted that, and this doesn’t fulfill that…
While we're asking questions on commitwindow.app - how do you tell it the status of various files, eg
CommitWindow.app/Contents/MacOS/CommitWindow fileA.txt dir1/fileB.txt
Will show those files in the commit window, and I can parse the output but I've not figure out how to tell commitwindow the status of the files I want it to show?
jebw
On 17 Nov 2007, at 08:48, Allan Odgaard wrote:
On 16 Nov 2007, at 17:16, Rick DeNatale wrote:
[...] When I tried to commit, it failed complaining about mixed line endings (paraphrasing from memory).
Never heard of such error before. Would that be the commit message itself that had the mixed line endings?
[...] I tried to figure out how to patch this, but I think that this is all handled within the internal CommitWindow.app which I can't (or don't know how to) look at.
The source for the CommitWindow is here: http://macromates.com/svn/ Bundles/trunk/Tools/CommitWindowProject/
The Ruby script which uses the CommitWindow is here: http:// macromates.com/svn/Bundles/trunk/Bundles/Subversion.tmbundle/ Support/svn_commit.rb
I wonder though if actually this is not more suitable for http:// bugreport.apple.com -- although NSTextView can handle mixed line endings, I don’t think reading stuff from the clipboard should ever result in anything but LF. Maybe though you got RTF on the clipboard, and NSTextView inserted that, and this doesn’t fulfill that…
For new threads USE THIS: textmate@lists.macromates.com (threading gets destroyed and the universe will collapse if you don't) http://lists.macromates.com/mailman/listinfo/textmate
On 19 Nov 2007, at 11:54, Jeremy Wilkins wrote:
While we're asking questions on commitwindow.app - how do you tell it the status of various files, eg
CommitWindow.app/Contents/MacOS/CommitWindow fileA.txt dir1/fileB.txt
You need to give --status and the argument is a :-separated string of status for the files.
…/CommitWindow fileA.txt dir1/fileB.txt --status M:A
To make first Modified the second Added.
Cheers for the response, works a treat.
Next question, how does the commands support work (ie the diff button next to files). I'm (v.slowly) working on a Bazaar plugin, I've had no time on this but will hopefully get some more time on this in the next month or so and should be ready after xmas, hopeful I can get it in the repo optional bundles at that point.
jeb
On 20 Nov 2007, at 11:27, Allan Odgaard wrote:
On 19 Nov 2007, at 11:54, Jeremy Wilkins wrote:
While we're asking questions on commitwindow.app - how do you tell it the status of various files, eg
CommitWindow.app/Contents/MacOS/CommitWindow fileA.txt dir1/fileB.txt
You need to give --status and the argument is a :-separated string of status for the files.
…/CommitWindow fileA.txt dir1/fileB.txt --status M:A
To make first Modified the second Added.
For new threads USE THIS: textmate@lists.macromates.com (threading gets destroyed and the universe will collapse if you don't) http://lists.macromates.com/mailman/listinfo/textmate
On 23 Nov 2007, at 12:12, Jeremy Wilkins wrote:
Next question, how does the commands support work (ie the diff button next to files). I'm (v.slowly) working on a Bazaar plugin, I've had no time on this but will hopefully get some more time on this in the next month or so and should be ready after xmas, hopeful I can get it in the repo optional bundles at that point.
TBH I have to look through existing bundle commands at the repository to answer these questions.
You may want to check out e.g. the Git bundle: http://macromates.com/svn/Bundles/trunk/Work%20in%20Progress/Bundles/Git.tmb... -- this is probably the smallest one that uses the CommitWindow.
Also the actual source for the commit window is in the repository.
Thanks, will do
jebw
On 26 Nov 2007, at 15:28, Allan Odgaard wrote:
On 23 Nov 2007, at 12:12, Jeremy Wilkins wrote:
Next question, how does the commands support work (ie the diff button next to files). I'm (v.slowly) working on a Bazaar plugin, I've had no time on this but will hopefully get some more time on this in the next month or so and should be ready after xmas, hopeful I can get it in the repo optional bundles at that point.
TBH I have to look through existing bundle commands at the repository to answer these questions.
You may want to check out e.g. the Git bundle: http:// macromates.com/svn/Bundles/trunk/Work%20in%20Progress/Bundles/ Git.tmbundle -- this is probably the smallest one that uses the CommitWindow.
Also the actual source for the commit window is in the repository.
For new threads USE THIS: textmate@lists.macromates.com (threading gets destroyed and the universe will collapse if you don't) http://lists.macromates.com/mailman/listinfo/textmate
-
Allan Odgaard -
Jeremy Wilkins -
Matt Brandt -
Rick DeNatale