I stumbled upon https://github.com/textmate/textmate/pull/1297. The PR says it was merged, but I think this was a mistake? What’s the current state of this? Would be really nice to use this for RuboCop, RSpec and co :-)
Stefan
On 07 Aug 2016, at 11:34, Stefan Daschek stefan@daschek.net wrote:
I stumbled upon https://github.com/textmate/textmate/pull/1297. The PR says it was merged, but I think this was a mistake? What’s the current state of this? Would be really nice to use this for RuboCop, RSpec and co :-)
Yes, it was a mistake and it was reverted. Last time the conclusion was that it needed some refactoring, i.e. using proper views (NSView) for the inline text instead of drawing the inline text directly on the document. It also needs support for hiding the inline text, because the current way how it handles inline text that is too long is very simplified. Allan has also started refactoring the some code that would affect the current implementation, not sure what the status is there.
— /Jacob Carlborg
On 7 Aug 2016, at 13:03, Jacob Carlborg wrote:
[…] Allan has also started refactoring the some code that would affect the current implementation, not sure what the status is there.
Been away for a few weeks, but things are still on track wrt. refactoring and I have a somewhat clear idea about how the inline marks should be handled: Rather than add boxes “right of text” I’ll put them below the line they refer to with an upward pointing arrow (if a column is given), then there is no space issue and makes the layout much easier.
I’ll probably do this as part of reworking the layout (which has a few pending items), but as usual there is no ETA or promises of anything.
On 07 Aug 2016, at 16:28, Allan Odgaard mailinglist@textmate.org wrote:
Been away for a few weeks, but things are still on track wrt. refactoring and I have a somewhat clear idea about how the inline marks should be handled: Rather than add boxes “right of text” I’ll put them below the line they refer to with an upward pointing arrow (if a column is given), then there is no space issue and makes the layout much easier.
What about the next line, if any?
The reason why I think it’s a good idea to place them on the right of the text is that if one has a fairly large widescreen display and follows the 80 column convention for line width, then there’s usually quite a lot of space to the right of the text.
-- /Jacob Carlborg
On 7 Aug 2016, at 21:17, Jacob Carlborg wrote:
I’ll put them below the line they refer to with an upward pointing arrow (if a column is given), then there is no space issue and makes the layout much easier.
What about the next line, if any?
It will push down the next line.
The reason why I think it’s a good idea to place them on the right of the text is that if one has a fairly large widescreen display and follows the 80 column convention for line width, then there’s usually quite a lot of space to the right of the text.
Clang is (nicely) verbose in its errors, often outputting 3-5 lines of text, so I think placing it to the right will often fail, so it’s not something I’ll pursue, but I do plan on looking into the “between lines” text myself.
On 07 Aug 2016, at 21:22, Allan Odgaard mailinglist@textmate.org wrote:
Clang is (nicely) verbose in its errors, often outputting 3-5 lines of text, so I think placing it to the right will often fail, so it’s not something I’ll pursue, but I do plan on looking into the “between lines” text myself.
Fair enough. I’ll be mostly happy as long as we get some kind of way of reporting errors without opening another interface (new window, tooltip and so on).
-- /Jacob Carlborg
-
Allan Odgaard -
Jacob Carlborg -
Stefan Daschek