On Wed, Apr 9, 2014 at 9:41 PM, Allan Odgaard <mailinglist@textmate.org> wrote:
On 10 Apr 2014, at 4:12, Ronald Wampler wrote:

I’ve always found this behavior confusing and would gladly see it replaced with just showing the message in the commit window where the user can then either keep it or edit it.


I do have a local change for the git bundle to include the last commit
message automatically.

You mean always show the last commit message, even when we are not doing an ammend? 
 
No, that should have read  "include the last commit message automatically when amending a commit" :(.


As for the "enable by default", the status could be
change to "?" or "X", I think, so that it is not enabled by default.

What does it mean to not have previous commit message enabled? That we are required to either enter a new message or enable it? I think we should strive for eliminating the item to clear up this confusion.
 
Looking at Git → Amend..., it appears if this is not enabled the commit message in the text view is not used (i.e., the last commit message is used). I agree with you that we could eliminate the item if we just auto fill the textview with the last commit message then the user can choose to edited it or not. This behavior would be consistent with the way amending a commit works when running "git commit --amend" from the command line.

Related to this I realize I forgot to implement the --log option. I will be submitting a patch soon to fix this regression.

I am willing to submit pull requests to make the necessary changes to the
git bundle to accommodate your comments, if that would be something of
general interest.

I would be happy to merge a pull request for showing last commit message for ammend (not in general), not opening HTML output window for cancel, and setting auto-save frame name for commit window.
Thanks, I will submit patches soon. 
 
 Tbh I am not too happy about the look of the bottom bar, but I haven’t been able to come up with something better.
Agreed. Unfortunately, I can't think of anything neither.
 


_______________________________________________
textmate mailing list
textmate@lists.macromates.com
http://lists.macromates.com/listinfo/textmate