<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 9, 2014 at 1:52 PM, Jacob Carlborg <span dir="ltr"><<a href="mailto:doob@me.com" target="_blank">doob@me.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
* The cancel button doesn't properly work. The other window that also opens still waits for a commit message (or something) after the commit window is closed<br></blockquote><div>Most of the functionality is actually controlled by the scm bundles. For the git bundle, it initially writes output to the html output window before opening the commit window. I have a pull request submitted to only show the html output window after closing the commit window (e.g., canceling or committing). Maybe we should also not send anything to the output window when canceling the commit too? So for this case (canceling) the other window would not be displayed at all.</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
* One thing that's been bugging me or quite a while is that when doing an amend the check box for updating the commit message is enabled by default but there's no commit message. The commit message of the commit being amended should automatically be inserted in the text view and all text should be selected. </blockquote>
<div> The commit window does accept a "--log" option that does just as you describe. Although I am not not aware of any bundle actually using this option (maybe the svn bundle??, I've only looked that the git and hg bundles). Also, the git bundle labels the "update commit message" as "M" which tells the commit window to enable it by default. <br>
</div><div><br></div><div>I do have a local change for the git bundle to include the last commit message automatically. As for the "enable by default", the status could be change to "?" or "X", I think, so that it is not enabled by default.</div>
<div><br></div><div>I am willing to submit pull requests to make the necessary changes to the git bundle to accommodate your comments, if that would be something of general interest.</div><div><br></div><div>Ron</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
<br>
<br>
______________________________<u></u>_________________<br>
textmate mailing list<br>
<a href="mailto:textmate@lists.macromates.com" target="_blank">textmate@lists.macromates.com</a><br>
<a href="http://lists.macromates.com/listinfo/textmate" target="_blank">http://lists.macromates.com/<u></u>listinfo/textmate</a><br>
</font></span></blockquote></div><br></div></div>