<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><DIV><DIV>On Apr 23, 2007, at 11:31 AM, Thomas Aylott (subtleGradient) wrote:</DIV><BLOCKQUOTE type="cite"><SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>On Apr 23, 2007, at 10:59 AM, Constantinos Neophytou ♎ wrote:</DIV><BLOCKQUOTE type="cite"><P style="margin: 0.0px 0.0px 0.0px 0.0px; color: rgb(0, 0, 221); "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica; color: rgb(0, 0, 221); "><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">if the last line of the javascript file is a comment with no new line at the end of it,</SPAN><SPAN class="Apple-converted-space"><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); "> </SPAN></SPAN><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">then the command "Minimize current file" produces this output:</SPAN></FONT></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; min-height: 14.0px; color: rgb(0, 0, 221); "><BR style="color: rgb(0, 0, 221); "></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; color: rgb(0, 0, 221); "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica; color: rgb(0, 0, 221); "><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">/Library/Application Support/TextMate/Bundles/JavaScript Tools.tmbundle/Support/bin/jsmin.rb:73:in `<=': comparison of Fixnum with String failed (ArgumentError)</SPAN></FONT></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; color: rgb(0, 0, 221); "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica; color: rgb(0, 0, 221); "><SPAN class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); white-space: pre; "> </SPAN></SPAN><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">from /Library/Application Support/TextMate/Bundles/JavaScript Tools.tmbundle/Support/bin/jsmin.rb:73:in `mynext'</SPAN></FONT></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; color: rgb(0, 0, 221); "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica; color: rgb(0, 0, 221); "><SPAN class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); white-space: pre; "> </SPAN></SPAN><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">from /Library/Application Support/TextMate/Bundles/JavaScript Tools.tmbundle/Support/bin/jsmin.rb:122:in `action'</SPAN></FONT></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; color: rgb(0, 0, 221); "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica; color: rgb(0, 0, 221); "><SPAN class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); white-space: pre; "> </SPAN></SPAN><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">from /Library/Application Support/TextMate/Bundles/JavaScript Tools.tmbundle/Support/bin/jsmin.rb:168:in `jsmin'</SPAN></FONT></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; color: rgb(0, 0, 221); "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica; color: rgb(0, 0, 221); "><SPAN class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); white-space: pre; "> </SPAN></SPAN><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">from /Library/Application Support/TextMate/Bundles/JavaScript Tools.tmbundle/Support/bin/jsmin.rb:197</SPAN></FONT></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; min-height: 14.0px; color: rgb(0, 0, 221); "><BR style="color: rgb(0, 0, 221); "></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; min-height: 14.0px; color: rgb(0, 0, 221); "><BR style="color: rgb(0, 0, 221); "></P><P style="margin: 0.0px 0.0px 0.0px 0.0px; color: rgb(0, 0, 221); "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica; color: rgb(0, 0, 221); "><SPAN class="Apple-style-span" style="color: rgb(0, 0, 221); ">The problem lying in the mynext method of jsmin.rb, where the while(true) loop checking for the end of the comment doesn't check for EOF. should be a simple fix.</SPAN></FONT></P></BLOCKQUOTE><BR><DIV>eep!</DIV><DIV>I'll fix that up right swift.</DIV><DIV>Thanks for the heads up!</DIV></SPAN></BLOCKQUOTE><BR></DIV><DIV>You were too right, it was really easy to fix.</DIV><DIV>I also went ahead and updated jsmin.rb to the latest version from crockford.com</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV style="font-size: 14px; "><B>Everyone: update your Javascript Tools bundle.</B></DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Here's a closed ticket</DIV><DIV><SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN><A href="http://dev.bundles.bundleforge.com/ticket/1">http://dev.bundles.bundleforge.com/ticket/1</A></DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>And the changeset</DIV><DIV><SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN><A href="http://dev.bundles.bundleforge.com/changeset/8">http://dev.bundles.bundleforge.com/changeset/8</A></DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>By the way, BundleForge is now secretly open.</DIV><DIV><SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN><A href="http://dev.bundles.bundleforge.com">http://dev.bundles.bundleforge.com</A>/</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>To combat spam, nobody is allowed to do anything without first creating an account and logging in.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV><DIV><SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN>thomas Aylott — <B>subtleGradient </B>— CrazyEgg — sixteenColors</DIV></DIV></BODY></HTML>