<div>I have thought about this and was thinking of using the TODO bundle to help out with this. I think avoiding the database approach would simplify things. It might not be as industrial strength, but is a much simpler implementation. </div> <div> </div> <div>The usage would go something like this:</div> <div> A person enters TODO tags within the code such as --BUG OPEN BLH This code is junk fix it please! The The format could be something like </div> <div>--<TYPE> <STATE> <INITIALS> <COMMENT></div> <div> </div> <div>After someone reviews a file they submit it to source control with their review comments included in the source. The only problem I see is if two separate reviewers comment on the same line when it comes time to submit to source control who's comment wins? This is what leans me back to a database implementation. My assumption is that there may be 4 or more reviewers reviewing the same code at any given time. </div> <div> </div> <div>Thanks</div> <div>Bob<br> </div> <div><span class="gmail_quote">On 4/16/07, <b class="gmail_sendername">Florian Gilcher</b> <<a href="mailto:flo@andersground.net">flo@andersground.net</a>> wrote:</span> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">-----BEGIN PGP SIGNED MESSAGE-----<br>Hash: SHA1<br><br>Hi,<br><br>this is an interesting suggestion. Have you considered to use <br>subversions (or some other version system) annotation feature instead of<br>a dedicated database? This would integrate the code reviews with the<br>versioning process which sounds like a nice idea. It would even give you <br>a nice interface to determining conflicts in the review process, which<br>could be reviewed... ;)<br><br>Greetings<br>Florian<br><br>Bob Henkel wrote:<br>> Hello,<br>><br>> I'm looking at creating a bundle that can be used to provide peer code <br>> reviews making use of TextMate for the majority if not all of the<br>> process. I'm looking for high level input/suggestions. Does anyone else<br>> think this would be helpful to them? Anyone else want to work on this <br>> with me?<br>><br>> The high level process of this goes like this:<br>> ( A database is used to store a code file for review and all comments<br>> submitted against that file. This allows metrics to be reported on as <br>> well as allowing any number of people to review the same code at the<br>> same time from many different locations. This also allows the status of<br>> comments to be tracked and changed and what not. I think I can push and <br>> pull data from a database pretty easily from TM. I'm looking at<br>> targeting PostgreSQL.)<br>><br>> 0. Code creator submits a file to be reviewed via TM.(Submitting<br>> actually inserts the code into the database) <br>> 1. Reviewer/s retrieves the stored file from the database and the file<br>> contents are displayed in TM(This is all done via TM).<br>> 2. Reviewer/s comments on a line by line basis or select multiple lines <br>> and comment via TM. Each comment should have a status such as BUG,<br>> STANDARDS BROKEN, GENERAL, etc. I'm thinking of using GUI integration<br>> to allow data input.<br>> 3. Code creator can comment on the comments left by a reviewer/s via TM. <br>> Example "I did this because of XYZ".<br>> 4. Code creator makes fixes in their code via TM based on reviewer/s<br>> comments.<br>> 5. Code creator submits changed code.<br>> 6. Reviewer/s can then flag a comment as FIXED, COMPLETED, CLOSED etc. <br>> These would be user configurable values I'm just showing these ones as<br>> an example.<br>> 7. Repeat 0 to 6 until all comments are in a FIXED/COMPELTE/CLOSED state.<br>> 8. Mark review in the database as completed. This will keep anyone from <br>> adding new comments. But the process above will all be in the database<br>> for future reporting and what not if it's needed.<br>><br>> Things I wish I could do, but not sure that I can:<br>> 0. I can't mark a line in TextMate with a little graphic in the left <br>> gutter to indicate that line has a comment on it. I do see maybe using<br>> the HTML viewer like the TODO bundle does as an alternative. Is it<br>> possible to highlight a line with a specific color on the fly? Say mark <br>> a line with a BUG comment and the line will turn red and lines with<br>> comments marked as GENERAL are yellow etc etc?<br>><br>> Thanks in advance for any input<br>> Bob<br>><br>><br>> ------------------------------------------------------------------------ <br>><br>><br>> ______________________________________________________________________<br>> For new threads USE THIS: <a href="mailto:textmate@lists.macromates.com">textmate@lists.macromates.com</a><br>> (threading gets destroyed and the universe will collapse if you don't) <br>> <a href="http://lists.macromates.com/mailman/listinfo/textmate">http://lists.macromates.com/mailman/listinfo/textmate</a><br>-----BEGIN PGP SIGNATURE-----<br>Version: GnuPG v1.4.3 (Darwin)<br>Comment: Using GnuPG with Mozilla - <a href="http://enigmail.mozdev.org">http://enigmail.mozdev.org</a><br><br>iD8DBQFGI8Ln8RlGMqQ8m7oRAgurAJ9Hk1rpiEhltXiy4zxsTiXJt4gdJACfVO5h<br>No/QWzieDiFRy4+rbbcafjo=<br>=hSys<br>-----END PGP SIGNATURE-----<br><br>______________________________________________________________________ <br>For new threads USE THIS: <a href="mailto:textmate@lists.macromates.com">textmate@lists.macromates.com</a><br>(threading gets destroyed and the universe will collapse if you don't)<br><a href="http://lists.macromates.com/mailman/listinfo/textmate"> http://lists.macromates.com/mailman/listinfo/textmate</a><br></blockquote></div><br>