<html><head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head><body bgcolor="#FFFFFF" text="#000000">Hi Allan, TextMate devs,<br>
<br>
First of all, many apologies for our long belated reply. We've been a
bit busy, and it doesn't help that we're not too great with proper time
management either. Thanks for the helpful information in your last
email, as it helped us figure out how exactly to tackle this challenge.
We decided to stick with that one instead of the others, since we had
already started on it a little by then.<br>
<br>
My colleague and I have issued a <a
href="https://github.com/textmate/textmate/pull/562">pull request</a>
for an elementary implementation of the undo support for browser pane
enhancement. The feature is incomplete since it only handles undo
actions for file deletion, pasting, renaming and new folder creation (we
did not implement undo for duplicating files or for the movement of
files within the pane). We tried our best to make it as stable as
possible, but we definitely realize it's probably still far from
perfect. There are likely a lot of issues with it actually — we'd be
happy to address any bugs that you encounter.<br>
<br>
We weren't really able to convert the class into MVC, though we hope
what we have now makes it easier to do in the future.<br>
<div class="moz-signature">-- <br>Thanks,<br>
Benjamin<br>
<br>
</div>
<br>
<br>
<blockquote style="border: 0px none;"
cite="mid:7F7740C7-F405-45CE-AEBC-B2F5870E21F7@textmate.org" type="cite">
<div style="margin:30px 25px 10px 25px;" class="__pbConvHr"><div
style="display:table;width:100%;border-top:1px solid
#EDEEF0;padding-top:5px"> <div
style="display:table-cell;vertical-align:middle;padding-right:6px;"><img
photoaddress="mailinglist@textmate.org" photoname="Allan Odgaard"
src="cid:part1.02030103.06050407@andrew.cmu.edu"
name="compose-unknown-contact.jpg" height="25px" width="25px"></div> <div
style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a moz-do-not-send="true" href="mailto:mailinglist@textmate.org"
style="color:#737F92
!important;padding-right:6px;font-weight:bold;text-decoration:none
!important;">Allan Odgaard</a></div> <div
style="display:table-cell;white-space:nowrap;vertical-align:middle;">
<font color="#9FA2A5"><span style="padding-left:6px">October 1, 2012
2:18 PM</span></font></div></div></div>
<div style="color:#888888;margin-left:24px;margin-right:24px;"
__pbrmquotes="true" class="__pbConvBody"><pre wrap="">On Oct 1, 2012, at 1:26 AM, Benjamin Madueme <a class="moz-txt-link-rfc2396E" href="mailto:bmadueme@andrew.cmu.edu"><bmadueme@andrew.cmu.edu></a> wrote:
</pre><blockquote type="cite"><pre wrap="">[…] If you guys are okay with us working on this issue, we'd appreciate it if we were given tips as to which source files deal with the file browser, and where we might want to implement this feature
</pre></blockquote><pre wrap=""><!---->
Sure, the file in question is this one <a class="moz-txt-link-freetext" href="https://github.com/textmate/textmate/blob/master/Frameworks/OakFileBrowser/src/OakFileBrowser.mm">https://github.com/textmate/textmate/blob/master/Frameworks/OakFileBrowser/src/OakFileBrowser.mm</a>
It should contain all the actions you can invoke from the file browser — I’d probably do a bit of refactoring though, trying to come up with more of a model (in MVC speak) that represent what the file browser can do, also to make it easier to change the visualization of the browser, re the mockup on the wiki: <a class="moz-txt-link-freetext" href="https://github.com/textmate/textmate/wiki/Main-Window">https://github.com/textmate/textmate/wiki/Main-Window</a>
</pre><blockquote type="cite"><pre wrap="">Otherwise, if you think there is something more important that we could work on, we'd be happy to do that instead.
</pre></blockquote><pre wrap=""><!---->
Important is rather subjective :) By far split view is the issue that has gathered the most comments, but I also think it’s pretty complex because the usability aspect is unclear and there are issues related to having multiple views of the same document then sharing caret/selections and undo/redo history.
If I were to suggest something then it would be <a class="moz-txt-link-freetext" href="https://github.com/textmate/textmate/issues/94">https://github.com/textmate/textmate/issues/94</a> — though rather than have the arrow expand/collapse the text fields, have them adapt in size similar to the text field used in Adium. If we had such adaptive text field, I would also use it in Preferences → Projects (for the pattern text fields) and other places where content can become one long line.
With the new constraint based layout this should be doable as a self-contained class as a view can now call [self invalidateIntrinsicContentSize] and trigger a relayout of the containing window.
Currently the Find window does not use constraint based layout, so it would need to be converted first. I’ll gladly help out with some of this.
_______________________________________________
textmate-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:textmate-dev@lists.macromates.com">textmate-dev@lists.macromates.com</a>
<a class="moz-txt-link-freetext" href="http://lists.macromates.com/listinfo/textmate-dev">http://lists.macromates.com/listinfo/textmate-dev</a></pre></div>
<div style="margin:30px 25px 10px 25px;" class="__pbConvHr"><div
style="display:table;width:100%;border-top:1px solid
#EDEEF0;padding-top:5px"> <div
style="display:table-cell;vertical-align:middle;padding-right:6px;"><img
photoaddress="bmadueme@andrew.cmu.edu" photoname="Benjamin Madueme"
src="cid:part1.02030103.06050407@andrew.cmu.edu"
name="compose-unknown-contact.jpg" height="25px" width="25px"></div> <div
style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a moz-do-not-send="true" href="mailto:bmadueme@andrew.cmu.edu"
style="color:#737F92
!important;padding-right:6px;font-weight:bold;text-decoration:none
!important;">Benjamin Madueme</a></div> <div
style="display:table-cell;white-space:nowrap;vertical-align:middle;">
<font color="#9FA2A5"><span style="padding-left:6px">September 30,
2012 7:26 PM</span></font></div></div></div>
<div style="color:#888888;margin-left:24px;margin-right:24px;"
__pbrmquotes="true" class="__pbConvBody">Hi there,<div><br></div><div>Me
and a classmate (cc'ed in this email) are university students who have
to contribute to an open source project for a programming class. As we
both have Objective-C experience (and both love the TextMate editor), we
decided to tackle the wonderful project of TextMate 2. We're supposed
to choose an existing request in the project's issue tracker and take
care of it.</div>
<div><br></div><div><span
style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif">We
decided to tackle </span><a moz-do-not-send="true" target="_blank"
style="color:rgb(17,85,204);font-size:13px;font-family:arial,sans-serif"
href="https://github.com/textmate/textmate/issues/17">this</a><span
style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif"> feature
request (add undo support to the file browser), since it looks like no
one's been assigned to it yet, and it's been around for a while. If you
guys are okay with us working on this issue, we'd appreciate it if we
were given tips as to which source files deal with the file browser, and
where we might want to implement this feature (we've built the project
and taken a look at some of the code, but we're admittedly a little lost
as to where to begin). Otherwise, if you think there is something more
important that we could work on, we'd be happy to do that instead.</span><br
style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif"
clear="all">
<div
style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif"><br></div><span
style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif">Thanks
so much!</span></div><div>Benjamin</div>
</div>
</blockquote>
<br>
<div class="moz-signature">-- <br>Thanks,<br>
Benjamin<br>
<br>
</div>
</body></html>