Looks like Michael Sheet is on a global renaming spree so I wait until it's over and update my files and commit them after. Looks like some of the things I fixed in my local copy (with the diff file attached to a msg earlier in this thread) have been fixed by other people in the last days.
<br><br><br><br><div><span class="gmail_quote">On 8/14/06, <b class="gmail_sendername">thomas Aylott</b> <<a href="mailto:oblivious@subtlegradient.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
oblivious@subtlegradient.com
</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div><span>
<div><div>On Aug 11, 2006, at 8:06 PM, Martin Ström wrote:</div><br><blockquote type="cite">Hi<br><br>As beeing the last grammar not to validate I tried to fix the scopes for "Prototype & Scriptaculous" bundle the other day. I have fixed the scopes to be valid and also moved a lot of common JavaScript things to the JS bundle instead. (the P+S grammar is now more or less just the classes and methods). I haven't commit the changes yet because there are some thing I wanted to check with you before doing my first commit :)
<br><br>Thomas Aylott: I have fixed some scopes things in your Bracketed theme (this was before the commit earlier today) and want you to check if it (and the other changes as well such as the Symbol List prefs) works as intendend.
<br><br>There are some difficulties with JS since there aren't any "real" classes (just functions) and how these should be scoped (like classes or functions). I choose to have some patterns to be scoped as classes (like the built-in Prototype classes like Element, Position or Effect, as well as "MyClass" in `MyClass.prototype` and some other cases). I don't know really what is the correct solution for this but I thought it's better to get the bundles cleaned and valid first and then we can think/change these scopes.
<br><br>Anyway, here's the diff from my WC. Remember that my WC is dated before Thomas Aylott's and Michael Sheets' commits the latest days. <br><br>Ciao<br>Martin<br clear="all"><br>-- <br><a href="http://burnfield.com/martin" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
burnfield.com/martin</a><br></blockquote><br></div></span></div><div><div>I've never done a patch before. what's the trick?</div>It just keeps asking me what files i want to patch and doesn't believe me when i tell it.<div>
<br></div><div><font face="Monaco" size="2"><span style="font-size: 10px;"><font color="#ff0000">can't find file to patch at input line 142</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;">
<font color="#ff0000">Perhaps you should have used the -p or --strip option?</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;"><font color="#ff0000">The text leading up to this was:
</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;"><font color="#ff0000">--------------------------</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;">
<font color="#ff0000">|Index: JavaScript Prototype & Script_aculo_us.tmbundle/Preferences/Symbol List Banned.tmPreferences</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;"><font color="#ff0000">
|===================================================================</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;"><font color="#ff0000">|--- JavaScript Prototype & Script_aculo_us.tmbundle/Preferences/Symbol List
Banned.tmPreferences (revision 4661)</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;"><font color="#ff0000">|+++ JavaScript Prototype & Script_aculo_us.tmbundle/Preferences/Symbol List
Banned.tmPreferences (working copy)</font></span></font></div><div><font face="Monaco" size="2"><span style="font-size: 10px;"><font color="#ff0000">--------------------------</font></span></font></div><div><font face="Monaco" size="2">
<span style="font-size: 10px;"><font color="#ff0000">File to patch:</font></span></font></div><div><br></div><div>Then no matter what i put in it rejects it.</div><div>How do you guys do it?</div><div><br><div> <span style="border-collapse: separate; border-spacing: 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;">
<span style="border-collapse: separate; border-spacing: 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;">
<div><font size="4"><span style="font-size: 14px;"><span style="font-size: 14px;"><span style="font-size: 14px;">thomas Aylott—</span></span></span></font><b style="font-weight: bold;"><span style="font-weight: bold;"><span style="font-weight: bold;">
subtleGradient</span></span></b></div></span><div><br></div><br></span></div></div><br></div>
</div><br><br>_______________________________________________<br>textmate-dev mailing list<br><a href="mailto:textmate-dev@lists.macromates.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">textmate-dev@lists.macromates.com
</a><br><a href="http://lists.macromates.com/mailman/listinfo/textmate-dev" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://lists.macromates.com/mailman/listinfo/textmate-dev</a><br><br><br>
</blockquote>
</div><br><br clear="all"><br>-- <br><a href="http://burnfield.com/martin" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">burnfield.com/martin</a>