<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; ">Oops, sorry, meant to send it to the list, not just Hadley.<BR><DIV><BR><DIV>Begin forwarded message:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><B>From: </B></FONT><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica">Charilaos Skiadas <<A href="mailto:cskiadas@uchicago.edu">cskiadas@uchicago.edu</A>></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><B>Date: </B></FONT><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica">June 23, 2005 11:50:14 PM CDT</FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><B>To: </B></FONT><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica">hadley wickham <<A href="mailto:h.wickham@gmail.com">h.wickham@gmail.com</A>></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><B>Subject: </B></FONT><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica"><B>Re: [SVN] Revision 1203 (markdown)</B></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV> <BR class="Apple-interchange-newline"><BR><DIV><DIV>On Jun 23, 2005, at 11:05 PM, hadley wickham wrote:</DIV><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">That's odd because when I run markdown preview it is italic - however,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">this seems to be because they're all in one paragraph.<SPAN class="Apple-converted-space"> </SPAN>I've split</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">each out into it's own paragraph to make this clearer.<SPAN class="Apple-converted-space"> </SPAN>I've also</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">changed _italic \_ _ to _italic\__ to make the test case work (and</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">match the bold example).<SPAN class="Apple-converted-space"> </SPAN>I've also added another test case to</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">demonstrate _ surrounded by space.</DIV></BLOCKQUOTE><DIV><FONT class="Apple-style-span" color="#0000DD"><BR class="khtml-block-placeholder"></FONT></DIV><DIV><FONT class="Apple-style-span" color="#0000DD">Yes, what happens is that in</FONT></DIV><DIV><FONT class="Apple-style-span" color="#0000DD"><BR class="khtml-block-placeholder"></FONT></DIV><DIV><FONT class="Apple-style-span" color="#0000DD"><FONT class="Apple-style-span" color="#000000">_italic \_ _</FONT></FONT></DIV><DIV>*italic__*</DIV><DIV><FONT class="Apple-style-span" color="#0000DD"><BR class="khtml-block-placeholder"></FONT></DIV><DIV><FONT class="Apple-style-span" color="#000000">the first underscore starts a search for emphasis. The second underscore is escaped, so does not matter. The third underscore has a space before it, so it is not considered as closing emphasis (I think the markdown documentation has a typo there, it should probably say "the opening emphasis is not followed by a space, and the closing emphasis is not preceded by a space" ). The search continues, and if finds the next underscore, which is valid, and hence closes it. The next underscore is just printed as is, since there is no closing underscore. Compare it with this:</FONT></DIV><DIV>_italic \_ _</DIV><DIV>*italic__*</DIV><DIV><FONT class="Apple-style-span" color="#000000">italic_</FONT></DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>in which case, the last underscore finds its match.</DIV><DIV><FONT class="Apple-style-span" color="#0000DD"><BR class="khtml-block-placeholder"></FONT></DIV><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Yes, neither version is correct, so obviously we need to create a</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">regexp that works for both.<SPAN class="Apple-converted-space"> </SPAN>The first step in fixing this is to</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">improve the test case (which I'll commit shortly) so we can fix it</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">without breaking anything else.<SPAN class="Apple-converted-space"> </SPAN>I also believe that combine the two</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">forms into one regular expression achieves little but making it more</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">complicated.</DIV></BLOCKQUOTE><BLOCKQUOTE type="cite"></BLOCKQUOTE><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Yes, I agree. Allan's suggestion does indeed fix the backslashes in the front, if you want to opt for that. I'll leave the decisions to you, you are probably more familiar with the bundle and with markdown, and at the moment I don't even have access to the repository, because my hard-drive died and after replacing it I haven't restored everything to its original condition. So I can't see at this time your changes to the test file, but here are some suggestions: First off, leave one empty line between cases, so that trailing underscores don't get confused with the next case. Empty lines will prompt markdown to break paragraphs, and hence stop the search for emphasis. So for instance:</DIV><DIV>_not italic</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>not end italic_</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>_italic</DIV><DIV>end italic_</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Here are some backslashes examples:</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>\\\\_italic\\_</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>\\\\_not italic\_</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>\\\_not italic\\_</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>\\\\_italic\\_</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>\\\\_italic\\\_\\\\_</DIV><DIV><BR class="khtml-block-placeholder"></DIV>In general, the test was lacking examples of things that are NOT as expected, IMHO. I'd be happy to contribute with more examples if it is helpful.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Hadley</DIV><DIV><BR class="khtml-block-placeholder"></DIV></BLOCKQUOTE></DIV><BR><DIV> <DIV>Charilaos Skiadas</DIV><DIV>Department of Mathematics</DIV><DIV>University of Chicago</DIV> </DIV><BR></BLOCKQUOTE></DIV><BR><DIV> <DIV>Haris</DIV><DIV><BR class="khtml-block-placeholder"></DIV> </DIV><BR></BODY></HTML>