[SVN] r8007 (TYPO3)

Michael Sheets mummer at whitefalls.org
Mon Aug 20 08:43:26 UTC 2007


On Aug 20, 2007, at 8:42 AM, Michael Sheets wrote:

> Added review comments.

Comments for discussion:

- Help command should not have a key equivalent. See [style guide][1].
- The ⌃M shortcut for 'Insert devLog|sysLog Entry' this is a bit  
high level, also as per the style guide should use ⌃⇧ or  
⌃⇧⌘. But most importantly this collides with the shortcut for  
[multi-stroke keybindings][2] many of us have installed from jacobolus.
- The 'Use Word / Selection as Marker' and such suffer the same issue.
- The debug and sub snippet triggers might be a bit generic since  
they would be active in all PHP files. There isn't any collision  
currently, just something to think about.
- fileTypes of tml and xml in T3DataStructure are too generic, would  
cause confusion. Should be left blank.

TypoScript Grammar:

- Invalid top level include key.
- comment.line scopes need trailing .typoscript
- Comment rules need $\n? added to the end to extend scope to end-of- 
line.

[1]: http://macromates.com/wiki/Bundles/StyleGuide
[2]: http://macromates.com/blog/2006/multi-stroke-key-bindings/


More information about the textmate-dev mailing list